[Bug 496677] Review Request: nfoview - Viewer for NFO files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496677





--- Comment #5 from Fabian Affolter <fabian at bernewireless.net>  2009-04-26 08:51:22 EDT ---
Thanks for the review.

(In reply to comment #2)
> Issues:
> - Unresolved deps on Fedora <= 10: terminus-font needs to be terminus-font-x11

fixed 

> - License is GPLv3, but is it GPLv3 only or GPLv3+?

see Comment #3

> - Desktop file contains the categories "GTK;Utility;Viewer;" but according to 
> http://standards.freedesktop.org/menu-spec/latest/apa.html Viewer belongs to
> Graphics or Office but not to Utilities. You may want to replace it with
> "TextTools" during desktop-file-install

fixed

> - Desktop file contains as mime type, but you are not running
> update-desktop-database, see
> https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database

-fixed

> - No need to include PKG-INFO in %doc  

fixed.  There are different opinions about to include this file or not.

Updated files:

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/nfoview.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/nfoview-1.4-2.fc10.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.