[Bug 492895] Review Request: xml-security-c - C++ Implementation of W3C security standards for XML

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492895


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #1 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-26 15:36:57 EDT ---
Some notes for 1.4.0-1:

* Calling autotools
  - Please avoid to use autotools as much as possible.
    Calling autotools can break things in many ways....

    For this package, just
-----------------------------------------------------------
%prep
%setup -q
sed -i.flags -e 's|-O2 -DNDEBUG|-DNDEBUG|' configure

%build
%configure --disable-static
make %{?_smp_mflags}
-----------------------------------------------------------
    is enough (and please remove unneeded BuildRequires)

* Timestamps
  - Please try to keep timestamps on installed files as
    much as possible (for this package, especially for
    installed header files).
    slightly related:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

    This package uses "install-sh". In this case, usually
-----------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT CPPROG="cp -p"
-----------------------------------------------------------
    works.

* Filename conflict
-----------------------------------------------------------
# yum --disablerepo=\* --enablerepo=koji-11 whatprovides '/usr/bin/xtest'
Loaded plugins: dellsysidplugin2
starlab-4.4.3-5.fc11.i586 : A Software Environment for Collisional Stellar
Dynamics
Repo        : koji-11
Matched from:
Filename    : /usr/bin/xtest

xml-security-c-1.4.0-1.fc11.i586 : C++ Implementation of W3C security standards
for XML
Repo        : installed
Matched from:
Other       : Provides-match: /usr/bin/xtest
-----------------------------------------------------------
  - This means the name "%_bindir/xtest" is already used by
    other packages in Fedora and cannot be used by this package.
    Anyway I don't think the name "%_bindir/xtest" is proper
    because its naming is too generic:
    https://fedoraproject.org/wiki/Packaging/Conflicts#Binary_Name_Conflicts

* Requires
  - For -devel subpackage, please check if all needed Requires
    are properly listed.
    ! For example, (note that I am only saying an example)
      %_includedir/xsec/dsig/DSIGXPathHere.hpp contains:
-----------------------------------------------------------
    26  #include <xsec/framework/XSECDefs.hpp>
    27  
    28  #include <xercesc/util/PlatformUtils.hpp>
-----------------------------------------------------------
      This means that xml-security-c-devel should have 
      "Requires: xerces-c-devel".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.