[Bug 493246] Review Request: Shutter -- a feature-rich screenshot program.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493246





--- Comment #6 from Jan Klepek <jan.klepek at hp.com>  2009-04-27 12:22:00 EDT ---
1]
what is meaning of share/shutter/resources/system/plugins directory in your
tarball?
in bash plugins you are using convert from imagemagick, without imagemagick in
requirements this plugins wouldn't work.
Are this plugins (both, perl and bash) needed for work of shutter? or they just
to extend functionality?

2]
in bin/shutter you have "use Proc::Simple" that's why rpmbuild add it as
requirements.

3] 
rpmlint is still not silent, no %build section in spec file
%build could be empty 

4] 
you have %doc without any file specified

5] 
during %prep you delete all files in app-install directory but no directory,
why not remove whole directory?

6] 
why do you want to have share/resources/modules in /usr? Do you have any reason
why not to put perl modules into better location?
see: http://fedoraproject.org/wiki/Packaging/Perl

7] 
please do not use "mv", use install -p or cp -p 
see: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.