[Bug 489564] Review Request: Blueman - Bluetooth Manager

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 27 20:40:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489564





--- Comment #30 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-27 16:40:29 EDT ---
Seems mostly fine.

- Builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1324720
- Packaged latest version
- Requires & provides sane
- Filelist ok
- Uses compiler flags correctly
- Patches present submitted upstream
- SPEC file clean, legible, written in American English

1.) RPMlint:

> blueman.src: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 4)
> The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
> annoyance.  Use either spaces or tabs for indentation, not both.

EasyFix

> blueman.src: W: patch-not-applied Patch0: blueman-build-pygtk.patch
> A patch is included in your package but was not applied. Refer to the patches
> documentation to see what's wrong.

With this not applied, it's probably not needed to require and run autoconf,
right?

2.) Summary & Description

Formatted text will not look good in GUIs. You may want to change the
description to be a descriptive paragraph instead of a bulleted list.

Summary may also need some improvement; I would not be able to decide whether I
want the application or not just by reading the summary. Please think of the
casual user; something like "Tool to manage Bluetooth enable devices" or might
be more appropriate.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list