[Bug 497441] Review Request: mumble - Voice chat application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #32 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-27 20:11:21 EDT ---
(In reply to comment #27)
> issues left i can currently see:
> 
> 1. mumble.logrotate needs to be copiedto %{buildroot}%{_sysconfdir}/logrotate.d
Done

> 
> 2. you might want to use runuser within the init script to get the daemon
> started as $DAEMONUSER
Fixed - its not working right now but will be fixed till tomorrow.(problem with
permissions I think)

> 
> 3. i still see /sbin/ldconfig: /usr/lib64/libmumble.so.1 is not a symbolic link
> (1.1.8-5)
Fixed

> 
> 4. the protocol file is kde4 stuff and needs to go to
> %{_datadir}/kde4/services/%{name}.protocol
Fixed

> 
> 5. murmur.conf (from scripts directory) needs to go to
> %{buildroot}%{_sysconfdir}/dbus-1/system.d/murmur.conf
Done

> 
> 6. id recommend adding no-embed-qt-translations because it gets rid of embedded
> qt translation probs.
Done

> 
> 7. id recommend adding no-update because we want to have users update the rpm
> way anyways.
Done

> 
> 8. adding DEFINES+=PLUGIN_PATH=%{_libdir}/%{name} cant really hurt
Done

> 
> 9. DEFINES+=DEFAULT_SOUNDSYSTEM=PulseAudio also makes sense to me.  
Done

(In reply to comment #29)
> Mumble doesn't depend on or use sqlite; it depends on Qt's sqlite database
> driver, which includes (or depends on) sqlite3. Same goes for DBus.
Done

> 
> Speaking of DBus, please include the murmur.conf file for registering murmur on
> the system dbus.
Done

> 
> Are there no builds of the g15daemon for Fedora? :(
In F9 nope.

> 
> Why do you have both a murmur.ini and a mumble-server.ini? You only need one,
> which should be whatever you use in the init file.
mumble-server.ini is symlink to murmur.ini

> 
> murmur.ini should be based on murmur.ini.system, not murmur.ini (which is
> intended for use when you run this from your home directory). Unless you happen
> to use the same paths as Debian, you'll need to regexp a few paths.
Fixed

> 
> When building on x86_64, you also need to build i386 libmumble.so, and stuff
> that in the appropriate directory. Otherwise you won't be able to use the
> overlay for 32-bit processes (which include most binary-only games).  


The issue with murmur.init will be fixed tomorrow - its pretty late here :)

SPEC: http://78.46.84.75:81/tj/etmain/mumble/mumble.spec
SRPM: http://78.46.84.75:81/tj/etmain/mumble/mumble-1.1.8-6.fc9.src.rpm
INIT: http://78.46.84.75:81/tj/etmain/mumble/murmur.init
DESKTOP MUMBLE: http://78.46.84.75:81/tj/etmain/mumble/mumble.desktop
DESKTOP OVERLAY: http://78.46.84.75:81/tj/etmain/mumble/mumble-overlay.desktop

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.