[Bug 497807] Review Request: perl-Capture-Tiny - Capture stdin or stdout from Perl, XS or external programs

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 28 04:19:36 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497807


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-28 00:19:35 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1322307
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
e242915f57878465ef0b947eaf2e0b5c  Capture-Tiny-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=8, Tests=316,  2 wallclock secs ( 0.12 usr  0.01 sys +  1.65 cusr  0.47
csys =  2.25 CPU)
+ Package perl-Capture-Tiny-0.05-1.fc12.noarch =>
  Provides: perl(Capture::Tiny) = 0.05
  Requires: perl >= 0:5.006 perl(Exporter) perl(File::Spec) perl(File::Temp)
perl(IO::Handle) perl(strict) perl(warnings)


Suggestions:
1) Again you included
BuildRequires:  perl >= 0:5.006
Remove that.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list