[Bug 497622] Review Request: apbs - adaptive poisson boltzmann solver

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 28 05:34:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497622


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-28 01:34:48 EDT ---
- What's this for?

%if %{fedora} < 11
%exclude %{_bindir}/psize.pyc
%exclude %{_bindir}/psize.pyo
%endif

- Instead of
 pushd bin
 make install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' CPPROG="cp -p"
 popd
and so onyou can just use
 make -C bin install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p' CPPROG="cp
-p"
 make -C src/aaa_lib install DESTDIR=$RPM_BUILD_ROOT INSTALL='install -p'
CPPROG="cp -p"


- Why do you generate autoconf files, aren't they distributed in the tarball..?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list