[Bug 491650] Review Request: libica - Library for accessing ICA hardware crypto on IBM zSeries

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491650


Darryl L. Pierce <dpierce at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #1 from Darryl L. Pierce <dpierce at redhat.com>  2009-04-29 17:09:23 EDT ---
Is the warning regarding no documentation considered fatal? Other than that,
this package looks fine to me. I'll approve this and the documentation issue
should be fixed or ignored.


MUST: rpmlint must be run on every package. The output should be posted in the
review.[1]

rpmlint output:

(mcpierce at mcpierce-laptop:Desktop)$ for rpm in *.rpm; do rpmlint $rpm; done
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
libica-devel.s390x: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
libica-utils.s390x: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture. [7]

MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun. [10] [OK]
MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. [19] [OK]
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} [22] [OK]

SHOULD: The reviewer should test that the package builds in mock. [29] [OK]
SHOULD: The package should compile and build into binary rpms on all supported
architectures. [30] [OK]

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.