[Bug 498413] Review Request: vfrnav - Flight Planning software for flights under Visual Flight Rules (VFR)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498413


Igor Jurišković <juriskovic.igor at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juriskovic.igor at gmail.com




--- Comment #1 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-30 08:34:09 EDT ---
Hello Thomas,

this is not official review. I'm in need of sponsor but I can tell you what can
be better or fixed.

- your Release: doesn't match changelog version.

- Group doesn't exist. You should use most appropriate Group available.
less /usr/share/doc/rpm-*/GROUPS* - will give you all possible groups.

- you dont need Require: gypsy. It will get pulled by gypsy-devel

- gcc-c++ is not needed. Read here why:
http://fedoraproject.org/wiki/Packaging/Guidelines

- in %files section you can omit INSTALL. You are making installation so other
users have no need to look into that file.

- NEWS is empty. You can remove it. Same goes for README 

- package doesn't own %{_datadir}/%{name} dir. Include it to %files section
with %dir.

- You can speed up packaging by using asterix(*) to own all files in some
directory. You can use this on
%{_datadir}/%{name}/* to own all files inside.


That's what I can see in fast - 10 minute - review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.