[Bug 507479] Review Request: moblin-cursor-theme - Moblin X cursors icon theme

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 3 23:10:17 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507479





--- Comment #8 from Peter Robinson <pbrobinson at gmail.com>  2009-08-03 19:10:16 EDT ---

> Yeah, but as I wrote I prefer using one of upstreams tarballs instead of the
> snapshot. Whatever can happen in the buildsys should happen there without
> manunally generating a tarball with an unpredictable md5sum.

Fixed. When I looked closer most of the Makefile was pointless!

Also from this:

> - Summary: 'Moblin X cursors icon theme' should be just 'Moblin X cursors
> theme', because cursors are no icons. On the other hand %decription could be
> more elaborate, e. g.: 'This package contains the Moblin X cursors theme.' or
> similar.

>From memory of a discussion on fedora-devel the package descriptions shouldn't
contain things like "This package contains" as by definition its a package (and
you shouldn't mention the package name in the summary) so I've left it as is
for the moment (except the removal of the word 'icon') due to lack of any
current inspiration on how to describe cursors :)

So I think all should be addressed here:

SPEC: http://pbrobinson.fedorapeople.org/moblin-cursor-theme.spec
SRPM: http://pbrobinson.fedorapeople.org/moblin-cursor-theme-0.3-2.src.rpm
koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1577625

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list