[Bug 517517] Package Review: perl-PPIx-EditorTools - Utility methods and base class for manipulating Perl via PPI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517517


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-08-14 09:24:31 EDT ---
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1605092
- rpmlint output for RPM and SRPM.
perl-PPIx-EditorTools.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1,
tab: line 14)
==> can be fixed using " sed -i -e 's|\t| |g' perl-PPIx-EditorTools.spec"
+ source files match upstream url
f9c74ff5642577e5369bac6375ffa06fa51998ba  PPIx-EditorTools-0.07.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=33,  1 wallclock secs ( 0.04 usr  0.01 sys +  0.89 cusr  0.09
csys =  1.03 CPU)

+ Package  perl-PPIx-EditorTools-0.07-1.fc12.noarch =>
Provides: perl(PPIx::EditorTools) = 0.07
perl(PPIx::EditorTools::FindUnmatchedBrace) = 0.07
perl(PPIx::EditorTools::FindVariableDeclaration) = 0.07
perl(PPIx::EditorTools::IntroduceTemporaryVariable) = 0.07
perl(PPIx::EditorTools::RenamePackage) = 0.07
perl(PPIx::EditorTools::RenamePackageFromPath) = 0.07
perl(PPIx::EditorTools::RenameVariable) = 0.07
perl(PPIx::EditorTools::ReturnObject) = 0.07

Requires: perl >= 0:5.008 perl(Carp) perl(Class::XSAccessor)
perl(Class::XSAccessor) >= 1.02 perl(File::Basename) perl(File::Spec) perl(PPI)
perl(PPI) >= 1.203 perl(PPIx::EditorTools::RenamePackage)
perl(PPIx::EditorTools::ReturnObject) perl(base) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.