[Bug 481030] Review Request: pmd-emacs - an interface to PMD for (X)Emacs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=481030





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-14 16:17:58 EDT ---
Joshua: rpmlint is not silent.

pmd-emacs-el.noarch: W: no-documentation
pmd-xemacs-el.noarch: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 2 warnings.

These are, however, OK.

**

As an (X)Emacs package, the Emacs guidelines are applied.
http://fedoraproject.org/wiki/Packaging:Emacs

The name of the package is incorrect, it should be emacs-common-pmd, and the
names of the other packages should be {x,}emacs-pmd{,-el}.

See e.g.
http://fedoraproject.org/wiki/Packaging:Emacs#Template_for_a_package_for_both_GNU_Emacs_and_XEmacs

**

If you're using a space to separate BR:s, don't use a comma in
Requires:       xemacs(bin) >= %{xemacs_version}, xemacs-packages-extra

As %install is a bit long, you could add additional space around it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.