[Bug 493013] Review Request: dzen2 - A general purpose messaging and notification program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493013


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #2 from Till Maas <opensource at till.name>  2009-08-25 02:31:12 EDT ---
Thx for your preliminary review.

(In reply to comment #1)

> * MUST: Packages containing GUI applications must include a %{name}.desktop
> file, and that file must be properly installed with desktop-file-install in the
> %install section. If you feel that your packaged GUI application does not need
> a .desktop file, you must put a comment in the spec file with your
> explanation....NEEDSWORK
>  - Not sure if these apps are considered GUI as they would run in a DE. They
> may need a .desktop file I'm not too sure on this but its a thought.

I can add a comment, why there is no .desktop file. It does not make sense to
have one, because dzen2 needs to get data from stdin, which cannot be passed if
it is run from a .desktop file.

> * MUST: If the package is designed to be relocatable, the packager must state
> this fact in the request for review, along with the rationalization for
> relocation of that specific package. Without this, use of Prefix: /usr is
> considered a blocker....NEEDSWORK

I do not use Prefix: /usr in the spec. This would be a Tag like "Name: dzen2"
or "Version 0.8.5" in the beginning of the spec file.

>  - Not sure if you need to use prefix in the configure and install sections as
> the {_prefix} macro is automatically appended to the build, even if source
> default is /usr/local/ it doesn't end there. At least from the package I built
> that defaults to /usr/local/ this is true. 

I am very sure that prefix is needed at least in %install, because it does not
use any special build system like autotools oder cmake. There the path is
passed to the makefiles using the %configure or %cmake macro. But here only
plain make files are used.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.