[Bug 508351] Review Request: josm - java openstreetmap editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=508351





--- Comment #5 from Andrea Musuruane <musuruan at gmail.com>  2009-08-02 09:22:26 EDT ---
I had a glance and I found the following issues:

* Release tag is still wrong. It should be 0.X.1788svn%{?dist} and not
1788svn%{?dist}. The first 0 indicate that this is a pre-release version. The X
is an incremented number (start at 1) you should bump at *each* new release.
1788svn is the svn version of the checkout you used.

* This is still wrong:

find -name '*.jar' -o -name '*.class' -exec rm -f '{}' \;

It should be:

find \( -name '*.jar' -o -name '*.class' \) -exec rm -f '{}' \;

Or:

find . -name '*.jar' -exec rm -f '{}' \;
find . -name '*.class' -exec rm -f '{}' \;

Therefore system jars are still not used, but I think you already knew this.

* Please don't use %{_builddir}/%{buildsubdir}. You already are in
%{_builddir}/%{buildsubdir}, so there is no need to specify it.

* And you should install the icon under
%{_datadir}/icons/hicolor/128x128/apps

and not under 
%{_datadir}/pixmaps/

You must also add the following to require the related file system package:
Requires: hicolor-icon-theme

* There is no useful documentation in javadoc files you generate.

* There is a duplicate BR:
BuildRequires:  java-devel 

You already have:
BuildRequires:  java-devel >= 1:1.6.0

* Another package you should make is bzip2 library:
http://www.kohsuke.org/bzip2/

You should not use the local copy.

* Please remove double spaces from summary and description.

HTH,

Andrea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.