[Bug 514928] Review Request: rubygem-fastercsv - FasterCSV is CSV, but faster, smaller and cleaner

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=514928


Jan Klepek <jan.klepek at hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jan.klepek at hp.com




--- Comment #1 from Jan Klepek <jan.klepek at hp.com>  2009-08-02 15:44:05 EDT ---
1] use global instead of define

2] summary should not start with name of application/library and there is
missing subject of that sentence. 
better summary would be "Library for ..." and specifying what this library
does.
does it parse csv files? or ... ?

3]
%if 0%{?rhel}%{?fedora} > 5
Requires: ruby(abi) = %{ruby_abiver}
%endif

it has to require ruby(abi) = 1.8 otherwise it conflict with ruby packaging
guidelines
https://fedoraproject.org/wiki/Packaging:Ruby

4] multiple listed files
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/AUTHORS
warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/CHANGELOG
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/COPYING
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/LICENSE
warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/fastercsv-1.5.0/README

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.