[Bug 507480] Review Request: moblin-icon-theme - Moblin icon theme

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 3 10:35:05 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=507480





--- Comment #13 from Peter Robinson <pbrobinson at gmail.com>  2009-08-03 06:35:04 EDT ---
I've updated the spec file using 'cp -p' as per the above guidelines it looks
like from my reading and testing install is only usable for individual files
rather than directory structure like in an icon theme.

I've also removed the Makefile.am files that are copied as well.

A side point I'm not sure how this script from the packaging guidelines works

%postun
if [ $1 -eq 0 ] ; then
    touch --no-create %{_datadir}/icons/hicolor &>/dev/null
    gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
fi

As post uninstall the theme.index wouldn't exist. I think it needs a -t option.

Thanks for the pointers.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list