[Bug 510743] Review Request: aranym - Atari Running on Any Machine

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 4 15:22:10 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510743


Andrea Musuruane <musuruan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |musuruan at gmail.com




--- Comment #4 from Andrea Musuruane <musuruan at gmail.com>  2009-08-04 11:22:08 EDT ---
(In reply to comment #3)
> 2: Don't you think the package name should be "ARAnyM" rather than "aranym"?
> The Naming Guidelines say: «If they refer to their application as "ORBit", you
> should use "ORBit" as the package name, and not "orbit".»
> (https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Case_Sensitivity)
> The website of the project seems to use "ARAnyM" consistently.

IMHO it is fine the actual package name.

"When naming a package, the name should match the upstream tarball or project
name from which this software came. In some cases, this naming choice may be
more complicated. If this package has been packaged by other
distributions/packagers in the past, then you should try to match their name
for consistency. In any case, try to use your best judgement, and other
developers will help in the final decision." 
(https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming)

Please note that upstream called its RPMs aranym-0.x.y-z.i386.rpm.

> (RPMlint also says:
> aranym.spec:62: W: configure-without-libdir-spec
> aranym.spec:69: W: configure-without-libdir-spec
> aranym.spec:73: W: configure-without-libdir-spec
> I can't really comment on that as I can't see the configure script.)  

This is usually given because you invoke configure directly and not the
%configure macro. Is there any reason in not using the macro?

HTH,

Andrea.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list