[Bug 515164] Review Request: gnomenu - A consolidated menu for gnome that brings eye candy to the world of the Gnome menu's

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515164


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-04 15:47:50 EDT ---
(In reply to comment #1)
> > gnomenu.noarch: E: explicit-lib-dependency python-xlib
> 
> Add python-xlib as a BuildRequires.

No, this is correct. RPM does not pick up requires of Python packages, they
have to be listed explicitly. rpmlint is misguided by the 'lib' in the
dependency.

**

Instead of BR: python you should BR: python-devel as per the Python packaging
guidelines.

**

You are using 'cp' in the spec file, so use -p to preserve timestamps.
http://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

**

The script-without-shebang warnings are probably caused by wrong permissions.
Remove the executable flags from the files with e.g.
 find %{buildroot} -type f -exec chmod 644 {} \;

**

You must own
 %{_datadir}/gnomenu/
as no other package provides it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.