[Bug 515206] Review Request: potrace - Transform bitmaps into vector graphics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515206





--- Comment #7 from Guido Grazioli <guido.grazioli at gmail.com>  2009-08-05 09:50:37 EDT ---
Hi Jussi, sorry to be a bit late, theres a couple of things below

** - rpmlint output
4 packages and 1 specfiles checked; 0 errors, 1 warnings.
potrace-devel.x86_64: W: no-documentation

- you could move potracelib.pdf from -doc to -devel (it's the library developer
manual) and let this warning go away

OK - The package must be named according to the Package Naming Guidelines.
OK - The spec file name must match the base package %{name}
OK - The package must meet the Packaging Guidelines
OK - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc

** - The package must be licensed with a Fedora approved license and
meet the Licensing Guidelines 

license in SPEC is : GPL+ and LGPLv2+
looking at README you can safely use: GPLv2+ and LGPLv2+

NA - Every binary RPM package which stores shared library files must
call ldconfig in %post and %postun (no shared libs)
OK - The package MUST successfully compile and build
koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1583585
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as
provided in the spec URL. 
e73b45565737d64011612704dd4d9f86  SOURCES/potrace-1.8.tar.gz
NA - The spec file MUST handle locales properly (no translations)
NA - package not relocatable
OK - A package must own all directories that it creates
OK - A Fedora package must not list a file more than once in the spec file's
%files listings
OK - Permissions on files must be set properly
OK - Each package must have a %clean section
OK - Each package must consistently use macros
OK - The package must contain code, or permissable content 
OK - Large documentation files must go in a -doc subpackage (-doc present)
OK - If a package includes something as %doc, it must not affect the runtime of
the application
OK - Header files must be in a -devel package (-devel present)
OK - Static libraries must be in a -static package (static library present, but
no shared libs, so everything goes in -devel)
NA - Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
OK - Packages must NOT contain any .la libtool archives
NA - Packages containing GUI applications MUST include a .desktop file (no gui)
OK - No file conflicts with other packages and no general names.
OK - At the beginning of %install, each package MUST run rm -rf %{buildroot}
OK - All filenames in rpm packages must be valid UTF-8
OK - The package does not yet exist in Fedora. The Review Request is not a
duplicate.
OK - %{?dist} tag is used in release

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.