[Bug 515034] Review Request: nss-softokn - Cryptographic Module of NSS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515034





--- Comment #7 from Elio Maldonado Batiz <emaldona at redhat.com>  2009-08-05 14:55:12 EDT ---
(In reply to comment #5)
Yes, the source tarball has "stripped" in the name because some some work was
done to remove non-free content.  Attachment (id=356396) shoes how some of the
processing is done.  I'll add more comments to the both spec files. This spec
file was derived from  the big nss.spec file and I tried not to deviate too
much from what it was already there and working. We do the install because
there is no install target in the upstream makefile. Need to check with Kai
about this.

> You're installing something into the prelink.conf.d/ dir but not Requiring
> prelink as far as I can tell.  That needs to be fixed.
Will do in the next iteration.
> 
> Your %files section has you taking ownership of the prelink.conf.d directory. 
> prelink and only prelink should own that.
> https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
Will respect ownership.

> Is there a particular reason why you use %dir for %{_includedir}/nss3 and then
> list a ton of files in it?  Are there files that you don't want to package that
> wind up in that directory?
For backward compatibilty with the previous usage the %{_includedir}/nss3
directory is common to nss-util, nss-softkn, and nss. Nss-softkn doesn't
populate the directory completely, nss-util would have placed files ther
earlier and nss would do likewise later. I was thinking of having
nss-util-devel own that directory so that the other two do not clobber it. Not
sure whether I'm aswering your question adequately here.

> I can't build this to test, because I'm missing nssutil-devel >= 3.12.3.99.3 
Yes , we need to somehow chain the build of nss-softkn with that of nss-util on
which it depends. I had problems using mosk but I was able to do rpmbuild -bi
on each when in the same rpmb building area.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.