[Bug 509856] Review Request: qrencode - The libqrencode library and application encodes QR Code symbols (2d barcodes)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=509856


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs at math.uh.edu




--- Comment #5 from Jason Tibbitts <tibbs at math.uh.edu>  2009-08-05 22:02:28 EDT ---
rpath is indeed generally a 64-bit thing.  Libtool somehow knows not to add
/usr/lib to rpath, but can't figure out not to add /usr/lib64.  That's libtool
for you.  However, when you add hacks like those sed calls over libtool, it's
best to also add a comment indicating why it's necessary.

You should not duplicate those doc files between the main and -devel packages.

Are you sure the license is GPLv2 only?  It looks like LGPLv2+ to me.  The
COPYING file contains the LGPL and the source code and upstream web site all
says:
 * [...] GNU Lesser General Public
 * License as published by the Free Software Foundation; either
 * version 2.1 of the License, or any later version.
which is what we call LGPLv2+.

Fix that up and I can go ahead and do a full review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.