[Bug 458866] Review Request: xls2csv - A script that recodes a spreadsheet's charset and saves as CSV

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458866





--- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-08-06 19:33:51 EDT ---
Björn Persson, thank you very much for the notes.

(In reply to comment #4)
> · I don't see the point in first including %{buildroot} in both PREFIX and
> DESTDIR and then hacking around the doubled buildroot that this causes. As far
> as I can see the build works just as well without %{buildroot} in PREFIX. It
> eliminates the need for the hack and makes RPMlint happy.
I fix it.

> · The guidelines say you shouldn't use both %{buildroot} and $RPM_BUILD_ROOT.
> Choose one or the other and stick to it.
> (https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS)
Ok.

> · You changed "rm" to "%{__rm}", so to be consistent you should use
> "%{__chmod}" as well.
Ok.

> (There doesn't seem to be a corresponding macro for
> "find".)
Yes. I also found it strange.

> Why do you use these macros by the way? What value do they add?
Really now - nothing. But if, when pathes changed - only one system macros
definition must be changed too opposite direct search/replace hundreds of
values.

> · According to the Perl packaging guidelines you shouldn't require Perl
> packages directly by name, but instead require the Perl modules by the
> "perl(Foo)" naming scheme.
> (https://fedoraproject.org/wiki/Packaging:Perl#Perl_Requires_and_Provides)
> 
> · Most of the explicit dependencies seem unnecessary, because RPMbuild will add
> dependencies automatically. ("Requires:" that is, not "BuildRequires:")

I remove perl and prel-modules requires.
But ppmbuild don't add next requires:
perl(:MODULE_COMPAT_5.10.0)
perl-Unicode-Map or perl(Unicode::Map)
perl-libintl
as you think, its really don't needed (excuse me, I'm dont very similar with
perl)?

>Please replace the tabs in the spec with spaces. They make the file look ugly
> in my editor, and in my web browser too. Apparently your editor has a
> different idea of tab width than mine.
Yes, I think 5 spaces tab width (it is convenient to easy distinguish pace and
tabs indent in each editor). I think it is not issue. Sorry, I don't want
change tabs to spaces.


http://hubbitus.net.ru/rpm/Fedora11/xls2csv/xls2csv.spec
http://hubbitus.net.ru/rpm/Fedora11/xls2csv/xls2csv-1.06-2.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.