[Bug 506833] Review Request: bisho - Moblin web services settings

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506833


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #8 from Christoph Wickert <fedora at christoph-wickert.de>  2009-08-06 20:53:03 EDT ---
(In reply to comment #7)
> 
> The comment I made in comment #4 was the same one. I didn't upload a new one
> there. Check the dates here http://pbrobinson.fedorapeople.org/

Sorry, my bad. I md5sum'ed and reviewed the wrong package (0.10.2) but the
correct spec, so I'm not going to start all over again.

> I've needed it for gtk based apps in the past, that's why I added it. I will
> investigate it tomorrow.

gnome-common can be dropped, I tested it. intltool and gettext are needed for
the locales, so the only thing left for autogen.sh is libtool. Just move the
comment down by three lines and it's correct.

Ok, now for 0.10.7 and the remaining issues:
OK - MUST: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/bisho-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: License field in spec file matches the actual license
OK - MUST: %{name}.desktop properly validated with desktop-file-validate

OK - SHOULD: The package builds in mock
OK - SHOULD: The package should compile and build into binary rpms on all
supported architectures.
OK - SHOULD: The package functions as described. However I noticed a small
annoyance: When hovering the close button in the top right corner, I get the
gtk-broken icon, although I have moblin-icon-theme-installed. Can you confirm
this? If so, I will look into that
OK - SHOULD: Scriptlets are sane.


Issues:
"INSTALL='install -p'" belongs to make install, not to make! Should be 
  make install DESTDIR=%{buildroot} INSTALL='install -p'

The summary still is "Moblin web services settings", you might want to change
that to to make Jeff happy.

Please fix the remaining issues. None of these are real blockers, so the
package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.