[Bug 513119] Review Request: PgsLookAndFeel - Nice looking LookAndFeel for Swing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513119


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review+              |




--- Comment #22 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-08-07 12:06:45 EDT ---
- You are missing Requires: jide-oss.

- Javadoc stuff has been fixed.

- I'd drop the versioning since at least in this case it isn't done by
upstream, as you
 install -D -p -m 644 jar/%{name}.jar \
 %{buildroot}%{_javadir}/%{name}-%{version}.jar
 install -D -p -m 644 jar/%{name}-jide.jar \
 %{buildroot}%{_javadir}/%{name}-jide-%{version}.jar

- Change
 %{_javadir}/*
to
 %{_javadir}/PgsLookAndFeel-jide.jar
 %{_javadir}/PgsLookAndFeel.jar
as it avoids the unnecessary wildcard which is troublesome e.g. when files are
missing.


With these notes the package is

APPROVED

please fix the issues before CVS import.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.