[Bug 516059] Review Request: dokuwiki - Standards compliant simple to use wiki

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=516059


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve.traylen at cern.ch




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-08-07 14:18:00 EDT ---
Hi Andrew,

 I think this is still an unofficial review from me. I have packager 
 status only just recently. I need to check what I can and can't do.

 1) Looking at the .spec you have a 
    cat <<EOF >%{name}.httpd
    # %{name}
     ...
    EOF

 I'm fairly sure Fedora says not to do this but I really can't find
 a reference at moment, ....
 Instead include an extra source file Source1: %{name}.

 And in %{prep}
 cp -p %{SOURCE1} .

2)
%post
/sbin/service httpd condrestart > /dev/null 2>&1 || :

%postun
/sbin/service httpd condrestart > /dev/null 2>&1 || :

a graceful will be enough(?) and has the advantage you won't end up
with a non-running server at the end since the config will be checked.
I'd be interested in policy on this situation since I'm working on another
package with the same situation.

3) I would consider moving the sed lines to the %build area.
The %install section should be limited to installing where ever possible.

4) Some trivial RPM errors.

$ rpmlint dokuwiki.spec ../SRPMS/dokuwiki-0-0.1.20090214.b.fc11.src.rpm \
    ../RPMS/noarch/dokuwiki-0-0.1.20090214.b.fc11.noarch.rpm 

dokuwiki.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1)
dokuwiki.src: W: mixed-use-of-spaces-and-tabs (spaces: line 20, tab: line 1)
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.