[Bug 513452] Review Request: mutter-moblin - Moblin Netbook plugin for Mutter

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513452


D. Marlin <dmarlin at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dmarlin at redhat.com




--- Comment #4 from D. Marlin <dmarlin at redhat.com>  2009-08-11 18:36:33 EDT ---

This package will not currently build due to a missing dependency:

from root.log
  DEBUG util.py:256:  No Package Found for bickley-devel

so a full review will have to wait for bickley.


configure will be run twice, once in the prep stage (through autogen.sh) and
once in the build stage.

  # run autogen.sh until we have a proper release, but don't run configure
twice.
  sed -i 's|echo|exit 0|g' autogen.sh
  ./autogen.sh

The 'sed' change does not appear to work for this autogen.sh script.  I think
the following command line change will:

  # run autogen.sh until we have a proper release, but don't run configure
twice.
  NOCONFIGURE=yes ./autogen.sh


It appears that the libraries are being included in the files lists twice
(duplicate):

  %files -f %{name}.lang
  %defattr(-,root,root,-)
  %doc COPYING README
  %{_libdir}/lib*.so.0*
  %{_libdir}/mutter/plugins/moblin-netbook.so.*
  %{_libdir}/lib*.so.0*    # duplicate
  %{_libexecdir}/moblin-panel*
    :

  %files devel
  %defattr(-,root,root,-)
  %{_libdir}/lib*.so
  %{_libdir}/mutter/plugins/moblin-netbook.so
  %{_libdir}/pkgconfig/*.pc
  %{_libdir}/lib*.so    # duplicate
  %{_includedir}/*

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.