[Bug 517507] Package Review: perl-Locale-Msgfmt - Compile .po files to .mo files

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 14 12:53:33 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517507





--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-08-14 08:53:31 EDT ---

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1605020
+ rpmlint is silent for RPM and SRPM.
+ source files match upstream url
767b2328e323eb06d0a9a5163b451d38748447ec  Locale-Msgfmt-0.14.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=5, Tests=16,  1 wallclock secs ( 0.05 usr  0.00 sys +  0.40 cusr  0.03
csys =  0.48 CPU)
+ Package perl-Locale-Msgfmt-0.14-1.fc12.noarch =>
  Provides: perl(Locale::Msgfmt) = 0.14 perl(Locale::Msgfmt::Utils) = 0.14
perl(Locale::Msgfmt::mo) = 0.14 perl(Locale::Msgfmt::po) = 0.14
perl(Module::Install::Msgfmt) = 0.14
Requires: /usr/bin/perl perl(File::Path) perl(File::Spec) perl(Getopt::Long)
perl(Locale::Msgfmt) >= 0.14 perl(Locale::Msgfmt::Utils)
perl(Locale::Msgfmt::mo) perl(Locale::Msgfmt::po) perl(Module::Install::Base)
perl(Module::Install::Share) perl(base) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list