[Bug 517466] Review Request: lbreakout2 - A breakout-style arcade game for Linux

bugzilla at redhat.com bugzilla at redhat.com
Sat Aug 15 18:43:31 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517466


Ed Brand <edbrand at brandint.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |edbrand at brandint.com




--- Comment #4 from Ed Brand <edbrand at brandint.com>  2009-08-15 14:43:30 EDT ---

The output of rpmlint looks clean. 

Giving your spec file a once over I see this:
Use %global instead of %define, unless you really need only locally defined
submacros within other macro definitions (a very rare case)
See:
https://fedoraproject.org/wiki/PackagingGuidelines#.25global_preferred_over_.25define

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list