[Bug 480724] Review Request: djbdns - A Domain Name System by D. J. Bernstein

bugzilla at redhat.com bugzilla at redhat.com
Tue Aug 18 14:04:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480724


Satya Komaragiri <skomarag at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skomarag at redhat.com




--- Comment #38 from Satya Komaragiri <skomarag at redhat.com>  2009-08-18 10:04:03 EDT ---
Unofficial review:

[?] The spec file from spec link does not match spec file provided in srpm ??
[?] Naming guideline: fine, but as you have branched an existing project and
changed it lot, it needs to be renamed.
[x] Builds successfully
http://koji.fedoraproject.org/koji/taskinfo?taskID=1611918
[x] License: Checked

[x] rpmlint 

bash-4.0$ rpmlint djbdns-1.05.3-1.fc11.i586.rpm 
djbdns.i586: W: conffile-without-noreplace-flag /etc/djbdns/tinydns.conf
djbdns.i586: W: conffile-without-noreplace-flag /etc/djbdns/servers/@
djbdns.i586: W: conffile-without-noreplace-flag /etc/djbdns/dnscache.conf

Two conf files need to have noreplace flag in %files section like
%config(noreplace) /etc/your_config_file_here

djbdns.i586: E: zero-length /etc/djbdns/ip/127.0.0.1

[?] Looks like this place will be populated by more empty files for some
functionality, but placing all of them in /etc/ does not make sense.

djbdns.i586: W: non-conffile-in-etc /etc/djbdns/ip/127.0.0.1
djbdns.i586: W: dangerous-command-in-%post ln
djbdns.i586: W: dangerous-command-in-%preun rm
1 packages and 0 specfiles checked; 1 errors, 6 warnings.


bash-4.0$ du -sh djbdns-debuginfo-1.05.3-1.fc11.i586.rpm 
436K djbdns-debuginfo-1.05.3-1.fc11.i586.rpm

file djbdns-1.05.3-1.fc11.i586/etc/djbdns/servers/@ lists root dns but name '@'
should be changed to something meaningful.

The package has too many servers and client side tools. It would make more
sense to package them as subpackages so that anyone who say wants to run
tinydns does not have to download whole djbdns tools in a single package.

[?] 

Use 

%preun
if [ $1 -eq 0 ] ; then
/sbin/chkconfig --del %{name}
fi

in preun section

and no need to create sym link. Simply install djbdns in /etc/init.d/ in
%install section e.g
mkdir -p $RPM_BUILD_ROOT/etc/init.d/
mv $RPM_BUILD_ROOT/%{_bindir}/djbns / $RPM_BUILD_ROOT/etc/init.d/

and include file in %files section


[?] The package does not own all directories e.g /etc/djbdns, /etc/djbdns/ip,
/etc/djbdns/servers/
bash-4.0$ rpmls djbdns-1.05.3-1.fc11.i586.rpm 
-rw-r--r--  /etc/djbdns/dnscache.conf
-rw-r--r--  /etc/djbdns/ip/127.0.0.1
-rw-r--r--  /etc/djbdns/servers/@
-rw-r--r--  /etc/djbdns/tinydns.conf

--------------------------------------------------

needs some fix in %files section

List:

[?] rpmlint done check above

[x] Package Naming Guidelines: OKay -But it is better to rename it.
[x]  Basepackage name matches spec name

[?]  License: Fine

Suggestion: Add license block at top in all source files. It seems after
re-licensing you have just updated license blocks in files which you have
modified. Other files should also get this block.

[x] License file in spec matches actual licenses mentioned in wiki

[?] Does not look like you are using RPM_OPT_FLAGS flags for compilation.

[x] spec file written in American English
[x] Legible
[x] Builds on ppc, ppc64, i586, x86_64

[?] Does not own all directories

[x] 

Extra Suggestions (unless you want this package to be imported into EPEL):
1. You can remove rm -rf $RPM_BUILD_ROOT from %install section - Not required
any more
2. You can also remove BuildRoot

?: Needs attention x: OKay

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list