[Bug 518205] Review Request: directory-naming - Directory Naming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518205


Andrew Overholt <overholt at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |overholt at redhat.com




--- Comment #5 from Andrew Overholt <overholt at redhat.com>  2009-08-19 10:41:54 EDT ---
A few issues:

- rpmlint output:
directory-naming.noarch: W: non-standard-group Development/Libraries/Java
directory-naming.noarch: W: wrong-file-end-of-line-encoding
/usr/share/doc/directory-naming-0.8/LICENSE.txt
directory-naming.noarch: W: non-conffile-in-etc
/etc/maven/fragments/directory-naming

- javadoc issues for naming-factory:
  [javadoc]
/notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/BeanFactory.java:64:
warning - Tag @link: reference not found:
org.apache.naming.config.XmlConfigurator
  [javadoc]
/notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/MailSessionFactory.java:59:
warning - Tag @link: reference not found:
org.apache.naming.config.XmlConfigurator
  [javadoc]
/notnfs/overholt/rpmbuild/BUILD/directory-naming-0.8/naming-factory/src/java/org/apache/naming/factory/SendMailFactory.java:81:
warning - Tag @link: reference not found:
org.apache.naming.config.XmlConfigurator

- there's a minor (a date in a comment) difference between the source that I
generate and the one in the SRPM

- I'd like to see a comment for the patch to the project files
- I removed the remaining sed lines for "setproxy" and the build was fine.  I
think they can be removed.

Otherwise, things look good.

It's nice that all of the test suites run and have no failures/errors.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.