[Bug 517859] Review Request: vmpsd - vmpsd is a GPL implementation of Cisco Systems' VMPS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517859





--- Comment #2 from Colin Coe <colin.coe at gmail.com>  2009-08-20 10:14:05 EDT ---
Hi Stjepan Gros, and thanks for the review.

My understanding is that it is OK to put the scripts in the spec file but I
will put it in the source if I'm wrong.

I've corrected to %preun and tidied up the rpmlint output.

rpmlint /home/coec/rpmbuild/SRPMS/vmpsd-1.4.01-1.fc11.src.rpm
/home/coec/rpmbuild/RPMS/i586/vmpsd-1.4.01-1.fc11.i586.rpm vmpsd.spec 
vmpsd.i586: W: service-default-enabled /etc/rc.d/init.d/vmpsd
2 packages and 1 specfiles checked; 0 errors, 1 warnings.

I should have advised that I need a sponsor also.

I've updated the spec and src.rpm.

Spec URL: http://members.iinet.net.au/~coec/vmpsd.spec
SRPM URL: http://members.iinet.net.au/~coec/vmpsd-1.4.01-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.