[Bug 518634] Review Request: plexus-digest - Plexus Digest / Hashcode Components

bugzilla at redhat.com bugzilla at redhat.com
Fri Aug 21 12:58:42 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=518634





--- Comment #3 from Alexander Kurtakov <akurtako at redhat.com>  2009-08-21 08:58:41 EDT ---
(In reply to comment #2)
> X please make lines 126 and 144 <= 80 characters
Fixed

> X please remove "ghost symlink" comment since it's no longer true
Fixed.

> X the license appears to be exclusively ASL 2.0; remove " and Plexus"
Fixed.

> 
> OK sources match what I download
> OK rpmlint output acceptable:
>  plexus-digest.noarch: W: no-documentation
>  plexus-digest.noarch: W: non-conffile-in-etc
> /etc/maven/fragments/plexus-digest
> Ok naming, versioning
> OK files
> OK requires
> OK builds
> OK macros
> OK rm -rf at beginning of %install and %clean present 

New sources:
Spec URL: http://akurtakov.fedorapeople.org/plexus-digest.spec
SRPM URL: http://akurtakov.fedorapeople.org/plexus-digest-1.0-8.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list