[Bug 515832] Review Request: libtelnet - TELNET protocol handling library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=515832





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-08-24 12:48:01 EDT ---
Some notes:

* URL
  - The URL written in the spec file seems 404.

* BuildRequires:
  - Would you explain why
    "BuildRequires: automake, autoconf, libtool, zlib-devel"
    are needed? It seems none of them is needed.

* %makeinstall
  - Please avoid to use %makeinstall unless unavoildable:
   
https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used

    Try to use
------------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
------------------------------------------------------------
    to also keep timestamps on installed files.

* %defattr
  - Now on Fedora %defattr(-,root,root,-) is preferred.

* About package structure
  - Would you explain why you want to create 5 binary rpms instead
    of just creating libtelnet and -devel binary rpms?
    The result binary rpms are very small (among current Fedora rpms),
    no other dependencies are needed when installing these packages
    and currently I don't see any benefit on creating 5 binary rpms.

Note that every time you modify your spec file please change the release
number to avoid confusion.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.