[Bug 517763] Review Request: voms - Virtual Organization Membership Service

bugzilla at redhat.com bugzilla at redhat.com
Mon Aug 24 22:30:06 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=517763


Steve Traylen <steve.traylen at cern.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |steve.traylen at cern.ch




--- Comment #1 from Steve Traylen <steve.traylen at cern.ch>  2009-08-24 18:30:04 EDT ---
Hi Mattias,

1) First the simple rpmlint errors.

voms.src:387: W: libdir-macro-in-noarch-package vomsjapi %{_libdir}/gcj/%{name}
  (Should be fixed)
voms-devel.x86_64: W: no-dependency-on voms/voms-libs/libvoms
   (I'm not sure what this is)
voms-devel.x86_64: W: no-documentation
    (okay)
voms-server.x86_64: E: subsys-not-used /etc/rc.d/init.d/voms
     (should be easy enough to add or maybe it looks like a <vo> specific lock 
      is created? Its tricky I don't know of anything else that launches 
      multiple deamons per configuration)
voms-server.x86_64: W: incoherent-init-script-name voms ('voms-server',
'voms-serverd')
     (okay)

2) Why is it?

%package -n vomsjapi
and not just
%package japi

3) After installing voms-server
# service voms start
ls: cannot access /etc/voms: No such file or directory
[root at globus x86_64]# echo $?
0

/etc/voms should be created and owned by the package.

I guess (not checked) voms is the directory containing the 
<vo>/voms.conf files? If so maybe /etc/voms.d/ might be better?

3.1) Is it worth adding an example configuration and perhaps a README.Fedora
      to describe simply how to get up and running? Create database., ...

4) Given there is no need to run voms as root ( except host cert) is 
   it a good idea to add a voms user and run as that? I realise it gets
   to a point where the init script ends up being written from scratch.

5) For my own education I expect in 
BuildRequires: globus-gssapi-gsi-devel%{?_isa}
why/how is the %{?_isa} added?

6) Concerning EPEL support this is probably only difficult because 
   of the bouncycastle requirment which requires a slew of missing 
    dependencies. Could it be built without the javaapi support? It
   is a lot less important I would say.

Steve.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list