[Bug 519236] Review Request: plexus-resources - Plexus Resource Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=519236


Jeff Johnston <jjohnstn at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jjohnstn at redhat.com
         AssignedTo|nobody at fedoraproject.org    |jjohnstn at redhat.com
               Flag|                            |fedora-review?,
                   |                            |needinfo?(overholt at redhat.c
                   |                            |om)




--- Comment #2 from Jeff Johnston <jjohnstn at redhat.com>  2009-08-25 16:31:34 EDT ---
rpmlint successful

Comments:

1. Packaging naming convention has the number incrementing ahead of the
   alphatag.  So release should be 0.2.a4 and then 0.3.a4 etc..

2. Javadoc description should not reference itself (use API documentation for
   xxx)

3. No %doc files

4. post and postun sections are maven-only.  Is this a problem since with_maven
   is 0?

5. defattr non-standard.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.