[Bug 510734] Review Request: x11vnc - VNC server for the current X11 session

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=510734





--- Comment #62 from Christian Krause <chkr at plauener.de>  2009-08-28 08:29:56 EDT ---
(In reply to comment #61)
> Whether the java applet is desired or not is a different question depending on
> its usefulness (the license question has already been checked). What is rather
> certain and would require an exception by the FPC otherwise is that if there
> are any java bits to be packaged they have to have been built by the package.

I fully agree. It is up to the packager whether we wants to add the java client
or not. I'm fine with either way.

> So, it's either
> 
> a) Rebuild the java support and the first step would be to remove the existing
> targets and add build support to the specfile or the upstream Makefile(s), or

Yes.

> b) don't add any java support, but you don't need to actually delete them
> during the build if they are not used in packaging, removing the folders from
> the main Makefile is enough (like in a diff further up the report).  

I agree that this may be debatable.
Personally think explicit deleting of the pre-built binaries in spec file in
the %prep section will make it quite obvious for anyone who looks at the spec
file later, that there is an issue with pre-built binaries which must be kept
in mind. That's all. ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.