[Bug 506855] Review Request hornsey - The moblin media player

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=506855





--- Comment #5 from Christoph Wickert <christoph.wickert at googlemail.com>  2009-08-29 23:28:42 EDT ---
Although we are still waiting for bickley, here is the formal part of the
review.

REVIEW FOR 
9ddf1cc689b20120ed787338eb4e4c6a  hornsey-0.3-1.fc12.src.rpm

TBD - MUST: rpmlint must be run on every package.
OK - MUST: named according to the Package Naming Guidelines
OK - MUST: spec file name matches the base package %{name}
OK - MUST: package meets the Packaging Guidelines
OK - MUST: Fedora approved license and meets the Licensing Guidelines: LGPLv2
OK - MUST: License field in spec file matches the actual license
OK - MUST: license file included in %doc
OK - MUST: spec is in American English
OK - MUST: spec is legible
OK - MUST: sources match the upstream source by MD5
1e959a8b2a70f059b502e05fe2c90687
OK - MUST: successfully compiles and builds into binary rpms on all arches
OK - MUST: all build dependencies are listed in BuildRequires.
OK - MUST: handles locales properly with %find_lang
N/A - MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun.
OK - MUST: Not relocatable.
OK - MUST: Owns all directories that it creates
OK - MUST: No duplicate files in the %files listing
OK - MUST: Permissions on files are set properly, includes %defattr(...)
OK - MUST: Package has a %clean section, which contains rm -rf %{buildroot}.
OK - MUST: consistently uses macros
OK - MUST: package contains code, or permissable content
OK - MUST: No large documentation
OK - MUST: Files included as %doc do not affect the runtime of the application
N/A - MUST: Header files must be in a -devel package
N/A - MUST: Static libraries must be in a -static package
N/A - MUST: Packages containing pkgconfig(.pc) files must 'Requires:
pkgconfig'.
N/A - MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
N/A - MUST: Devel packages must require the base package using a fully
versioned dependency: Requires: %{name} = %{version}-%{release}
OK - MUST: The package does not contain any .la libtool archives.
OK - MUST: The package contains a GUI application and includes a
%{name}.desktop file, and that file is properly validates with
desktop-file-validate in the %install section.
OK - MUST: packages does not own files or directories already owned by other
packages.
OK - MUST: at the beginning of %install, the package runs rm -rf %{buildroot}.
OK - MUST: all filenames valid UTF-8


SHOULD Items:
OK - SHOULD: Source package includes license text(s) as a separate file.
OK - SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available.
TBD - SHOULD: builds in mock.
TBD - SHOULD: compiles and builds into binary rpms on all supported
architectures.
TBD - SHOULD: functions as described.
OK - SHOULD: Scriptlets are used, those scriptlets must be sane.
N/A - SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
N/A - SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,
and this is usually for development purposes, so should be placed in a -devel
pkg.
OK - SHOULD: No file dependencies outside of /etc, /bin, /sbin, /usr/bin, or
/usr/sbin.

Other items:
OK - latest stable version packaged
OK - proper debuginfo package
OK - compiler flags honored
OK - timstamps preserved during install


Issues:
- Apply the patch from comment #3.
- Description does not end with a dot.
- Description is a little sparse. How about: Hornsey is a Image, Audio and
Video media browser and player for Moblin.  (taken from README)
- hornsey.desktop contains a mime type, but package lacks scriptlets from
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
- AUTHORS and README are missing from %doc
- MINOR: desktop file should get "Player" as additional category to allow
nested menus like in the studio spin. Doesn't really matter for Moblin though.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.