[Bug 520278] Review Request: notify-osd - Canonical's on-screen-display notification agent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520278


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de>  2009-08-30 04:37:07 EDT ---
Hello Heyde,

according to the Fedora Account System you're not yet an approved packager.
Thus, you need a sponsor doing the formal review of this package. (see
https://fedoraproject.org/wiki/PackageMaintainers/Join#Create_Your_Review_Request)

I had a quick look at your package and noticed a couple of issues.

$ rpmlint notify-osd-0.9.11-1.fc11.src.rpm 
notify-osd.src: E: description-line-too-long Canonical's on-screen-display
notification agent, implementing the freedesktop.org Desktop Notifications
Specification with semi-transparent click-through bubbles.
notify-osd.src: W: non-standard-group Desktop Environments/GNOME
notify-osd.src:64: E: files-attr-not-set
notify-osd.src:65: E: files-attr-not-set
1 packages and 0 specfiles checked; 3 errors, 1 warnings.

- You should split the %description text to several lines with max. 80
characters per line.

- Choose a proper package group

- move %defattr(-,root,root,-) to the top of the %file section

- The package doesn't build in mock because of a missing BuildRequires:
libnotify-devel. Also, BuildRequires and Requires contain many redundant
dependencies. It should be sufficient to give:

BuildRequires: GConf2-devel
BuildRequires: libwnck-devel
BuildRequires: dbus-glib-devel
BuildRequires: glib2-devel
BuildRequires:  libnotify-devel

- Add your email address to the %changelog entry

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.