[Bug 520477] Review Request: picprog - Microchip PIC micro-controller serial programmer software

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=520477


Martin Gieseking <martin.gieseking at uos.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |martin.gieseking at uos.de
             Blocks|                            |177841(FE-NEEDSPONSOR)




--- Comment #1 from Martin Gieseking <martin.gieseking at uos.de>  2009-08-31 14:03:46 EDT ---
Hello Alex,

I'm not a sponsor but nevertheless some quick comments from me. :)

- according to the source headers, the license is GPLv2 only
- add comments to the referenced patches about what they do
- it shouldn't be necessary to give the BuildRequires and Requires dependencies
- "make dep" is redundant

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.