[Bug 513083] Review Request: gbirthday - birthday reminder for evolution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=513083


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Christoph Wickert <cwickert at fedoraproject.org>  2009-08-31 18:13:56 EDT ---
OK, let's see what we've got in gbirthday-0.4.2-1.fc11.src.rpm

OK - MUST: $ rpmlint
/var/lib/mock/fedora-rawhide-x86_64/result/gbirthday-0.4.2-1.fc12.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - MUST: The spec file for the package is legible, changelog look fine now
OK - MUST: SourceO URL is correct
OK - MUST: The sources used to build the package match the upstream
source by MD5 c117a6b90e51d836ed2590e6f0f48164
OK - MUST: Permissions on files are set properly.
OK - SHOULD: License block added
OK - SHOULD: ChangeLog was added
OK - No more hardcoded path in desktop file
OK - Autostarts only in desktops known to have a systray

Famous last words:
- The spec in the Sourec0 tarball still is at 0.4.1-5 but I guess this is a
chicken and egg problem.
- Would be nice if install also preserved time stamps. Ether add '-p' or make
the Makefile accept as an argument, so one could use:
  make install DESTDIR=%{buildroot} INSTALL='install -p'
in the spec. But these are minor and should be targeted upstream. Thanks for
taking care of this program BTW.

No blockers left, the gbirthday-0.4.2-1.fc11.src.rpm is APPROVED.


Next steps:
- Get yourself a Fedora accound and tell me it's name:
https://fedoraproject.org/wiki/PackageMaintainers/Join#Get_a_Fedora_Account
- Request the CVS admin procedure:
https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.