[Bug 542292] Review Request: mintmenu - gnome-panel menu from LinuxMint

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542292


Christoph Wickert <cwickert at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cwickert at fedoraproject.org




--- Comment #10 from Christoph Wickert <cwickert at fedoraproject.org>  2009-12-01 10:43:12 EDT ---
sed is ok, but should be done in %pre, so that package doesn't need to be
touched after installation. If possible, try to preserver the timestams of the
files, see 
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks

I wonder it tracker is really sufficient or if tracker-search-tool is required.
I think it is.

%{_bindir}/mintmenu runs gconftool-2, so "Requires: Gconf2" is missing.

%{_bindir}/mintmenu should be installed in %{_libexecdir}

For licensing reasons, you are not allowed to include any Fedora icons in the
package. You must use the logos provided by the fedora-logos package and
Require: system-logos. system-logos is a virtual provides, so the package can
be rebranded.
If possible, use a generic name for the icon in the code, e.g.
"icon-panel-menu.png" which is provided by different themes and on several
distros such as Rhel or CentOS.

Not sure about license of the mint icon, I think best is to leave it out.

Disable building the empty debuginfo package with "%global debug_package
%{nil}" at the beginning of the spec.

/usr/lib64/bonobo/servers/mintMenu.server must not be executable, this is what
causes the script-without-shebang error in rpmlint. I'd rather use install than
cp because you can set proper permissions of the files.

(In reply to comment #6)
> How does one specify /usr/lib in a no arch package without using an absolute
> path?  This is where upstream places the files.

%{_prefix}/lib, see http://fedoraproject.org/wiki/Packaging:RPMMacros
But I agree with Terje that the noarch stuff should be moved to %{_datadir}.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.