[Bug 544873] Review Request: gitweb-caching - Gitweb w/ simple file caching

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544873


Jon Stanley <jonstanley at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #1 from Jon Stanley <jonstanley at gmail.com>  2009-12-06 21:54:00 EDT ---
Some issues:

- There is no version in the changelog -
https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
- The git checkout sha1 needs to be included in the release - see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
- The URL field shouldn't be the location of the source tarball, but rather a
place that I can find out more about what the package does. (maybe somewhere at
git-scm.org)
- The Source0 should, if possible, be a URL (all except the last element of the
URL is tossed by rpmbuild) of where to download the package.  See
https://fedoraproject.org/wiki/Packaging:SourceURL#Troublesome_URLs

Since Fedora 10 is no longer supported (and this will always be noarch anyways
- the reason that this was in the original gitweb is that prior to F10 noarch
subpackages were not supported), we can remove this from the spec:

%if 0%{?fedora} >= 10
BuildArch:      noarch
%endif

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.