[Bug 542292] Review Request: mintmenu - gnome-panel menu from LinuxMint

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=542292





--- Comment #11 from William Witt <william at witt-family.net>  2009-12-01 22:06:42 EDT ---

(In reply to comment #10)
> sed is ok, but should be done in %pre, so that package doesn't need to be
> touched after installation. If possible, try to preserver the timestams of the
> files, see 

moved sed-foo to %pre

> I wonder it tracker is really sufficient or if tracker-search-tool is required.
> I think it is.

changed...

> %{_bindir}/mintmenu runs gconftool-2, so "Requires: Gconf2" is missing.

Added

> %{_bindir}/mintmenu should be installed in %{_libexecdir}

I have to disagree on this one, libexdir takes it off the path.  The mintmenu
script allows the menu to be cleaned or or launched from the command line in
its own window.

> For licensing reasons, you are not allowed to include any Fedora icons in the
> package. You must use the logos provided by the fedora-logos package and
> Require: system-logos. system-logos is a virtual provides, so the package can
> be rebranded.
> If possible, use a generic name for the icon in the code, e.g.
> "icon-panel-menu.png" which is provided by different themes and on several
> distros such as Rhel or CentOS.
> 
> Not sure about license of the mint icon, I think best is to leave it out.


removed both mint and fedora logos, replaced with
/usr/share/icons/Bluecurve/24x24/apps/icon-panel-menu.png

> 
> Disable building the empty debuginfo package with "%global debug_package
> %{nil}" at the beginning of the spec.
> 

Done

> /usr/lib64/bonobo/servers/mintMenu.server must not be executable, this is what
> causes the script-without-shebang error in rpmlint. I'd rather use install than
> cp because you can set proper permissions of the files.

Done

> (In reply to comment #6)
> > How does one specify /usr/lib in a no arch package without using an absolute
> > path?  This is where upstream places the files.
> 
> %{_prefix}/lib, see http://fedoraproject.org/wiki/Packaging:RPMMacros
> But I agree with Terje that the noarch stuff should be moved to %{_datadir}.  

I moved as much as I can to %{_datadir}, but as I said the bonobo stuff needs
to be in /usr/lib or /usr/lib64, using %{_prefix}/lib sets off hardcoded
errors. I don't think there is a way around that while still keeping the
package no arch, which it really should be.  If this is acceptable, I can keep
it this way.


[unamanic at gimli ~]$ rpmlint
/home/unamanic/rpmbuild/RPMS/noarch/mintmenu-4.9.0-10.fc12.noarch.rpm
mintmenu.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
[unamanic at gimli ~]$ rpmlint
/home/unamanic/rpmbuild/SRPMS/mintmenu-4.9.0-10.fc12.src.rpm
mintmenu.src:73: E: hardcoded-library-path in
%{buildroot}/usr/lib/linuxmint/mintMenu/mint*.png
mintmenu.src:74: E: hardcoded-library-path in
%{buildroot}/usr/lib/linuxmint/mintMenu/mint*.svg
mintmenu.src:82: E: hardcoded-library-path in %{_prefix}/lib/bonobo/servers/
mintmenu.src:83: E: hardcoded-library-path in
%{_prefix}/lib/bonobo/servers/mintMenu.server
mintmenu.src:91: E: hardcoded-library-path in
%{_prefix}/lib/bonobo/servers/mintMenu.server
1 packages and 0 specfiles checked; 5 errors, 0 warnings.

koji:     https://koji.fedoraproject.org/koji/taskinfo?taskID=1842604
Spec URL: http://www.witt-family.net/mintmenu.spec
SRPM URL: http://www.witt-family.net/mintmenu-4.9.0-10.fc12.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.