[Bug 543608] New: Review Request: udisks

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 2 18:04:27 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: udisks

https://bugzilla.redhat.com/show_bug.cgi?id=543608

           Summary: Review Request: udisks
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: davidz at redhat.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Spec URL:
http://people.freedesktop.org/~david/udisks-pkg-review/20091202/udisks.spec
SRPM URL:
http://people.freedesktop.org/~david/udisks-pkg-review/20091202/udisks-1.0.0-0.git20091202.fc13.src.rpm

Description:

DeviceKit-disks recently got renamed to udisks, see

 http://lists.freedesktop.org/archives/devkit-devel/2009-December/000567.html

so it is only proper to change the Fedora package name too. This package will
obsolete (and provide - for transitioning) DeviceKit-disks. 

It is important to note that DeviceKit-disks has never claimed to provide a
stable ABI or API, see

 $ head -9 /usr/share/doc/DeviceKit-disks-009/NEWS
 -------------------
 DeviceKit-disks 009
 -------------------

 DeviceKit-disks is a daemon that provide interfaces to obtain
 information and perform operations on storage devices.

 NOTE NOTE NOTE: This is an unstable release of DeviceKit-disks, all
                 API is subject to change.
 $ rpm -qf /usr/share/doc/DeviceKit-disks-009/NEWS
 DeviceKit-disks-009-3.fc12.x86_64

so changing the name is no different than uploading a new DeviceKit-disks
package. 

Note also that the new udisks packages provide slightly stronger ABI and API
guarantees (see the mail linked to above) so packages using it should be able
to do

 Requires:  udisks >= 1.0.<something>
 Requires:  udisks < 1.1.0

instead of the mess we have today.

The main user, gnome-disk-utility, will use udisks in the next version.

The only other user of DeviceKit-disks (according to 'repoquery --whatrequires
DeviceKit-disks') is the emelfm2 package. It should be easy for that package to
transition (the gnome-disk-utility patch is ~200 lines - mostly just changing
the D-Bus bus names and interfaces) and emelfm2 would have to _anyway_ because
DeviceKit-disks never claimed to support any stable ABI or API - e.g. the next
DeviceKit-disks version could have used a completely different ABI.

The spec file is based on the existing DeviceKit-disks one with a few cleanups.

 $ rpmlint udisks.spec 
 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

 $ rpmlint ../SRPMS/udisks-1.0.0-0.git20091202.fc13.src.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 $ rpmlint ../RPMS/x86_64/udisks-devel-1.0.0-0.git20091202.fc13.x86_64.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.

 $ rpmlint ../RPMS/x86_64/udisks-1.0.0-0.git20091202.fc13.x86_64.rpm 
 udisks.x86_64: W: non-conffile-in-etc /etc/profile.d/udisks-bash-completion.sh
 udisks.x86_64: E: non-standard-dir-perm /var/run/udisks 0700
 udisks.x86_64: W: non-conffile-in-etc
/etc/dbus-1/system.d/org.freedesktop.UDisks.conf
 udisks.x86_64: E: non-standard-dir-perm /var/lib/udisks 0700
 1 packages and 0 specfiles checked; 2 errors, 2 warnings.

Both warnings and errors should be waived - reasons

 o /etc/profile.d/udisks-bash-completion.sh isn't a config-file at
   all - it is a shell script for bash completion

 o /etc/dbus-1/system.d/org.freedesktop.UDisks.conf - if users/admins
   wants to override D-Bus config directives (they have no reason to
   do this though) they can drop files in /etc/dbus-1/system.d. Note
   that we have talked in the D-Bus project about using $datadir or
   $libdir for these kinds of files. It might happen.

   This is also the case for every other package using the D-Bus
   system bus.

 o /var/run/udisks and /var/lib/udisks needs these permissions because
   we don't want to disclose this data to other users (might be an
   information leak to let everyone know that a user has mounted a disk)

Thanks for reviewing this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list