[Bug 543840] Review Request: udis86 - A x86 disassembler library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=543840


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-12-03 08:32:34 EDT ---
A few notes:

- The source url should be
 http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
see http://fedoraproject.org/wiki/Packaging/SourceURL. (Mark this as Source0.)

- Remove the commented empty Requires: line.

- The summary should read "A disassembler Library for x86 and x86-64" (not just
for x86).

- Move
 # test the libudis86 we just built this is the only part that requires yasm
 export LD_LIBRARY_PATH=$(pwd)/libudis86/.libs
 make check
to the %check phase.

- Remove the documentation installed by make install at the end of %install
with
 rm -rf %{buildroot}%{_docdir}
and list the relevant files instead as %doc, i.e.

%doc docs/x86optable.* docs/udis86.* docs/index.html docs/ss.jpg docs/style.css

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.