[Bug 538190] Review Request: unicornscan - Scalable, accurate, flexible and efficient network probing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=538190


Stepan Kasal <skasal at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |skasal at redhat.com




--- Comment #6 from Stepan Kasal <skasal at redhat.com>  2009-12-03 19:07:17 EDT ---
(In reply to comment #2)
> Autoconf creates a busted configure file on Rawhide, [...]
> bug #544039 (which I opened now for this).

Well, as explained in bug #544039, the Autoconf sources in that project are
borked, though they, by mere luck, happen to produce usable output with certain
versions of Autoconf.

But since your patch to configure.ac is very simple, I suggest that you do the
same change to the generated configure and include it to the patch.
It seems more adequate in this particular case.
With that, you do not need to run autoconf, so you do not need to care about
all the issues with the upstream Autoconf sources.

A side note: if a package runs autconf, I prefer to do it at the begining of
%build, so that %prep is only a cheap unpack, without any significant
computation.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.