[Bug 544540] Review Request: genesis - Graphical frontend to SyncEvolution

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=544540


Dominic Hopf <dmaphy at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #3 from Dominic Hopf <dmaphy at fedoraproject.org>  2009-12-05 11:25:31 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> 
> Thanks for your review Dominic!
> 
> > Issues found:
> >  * You're using $RPM_BUILD_ROOT in line 51 and line 67, but %{buildroot} in
> >    line 60 and 61. This affects required consistency of used macros.
> 
> I updated the SPEC file accordingly.
Looks good now, thanks.

> >  * The program is translated into several languages, it would be nice if there
> >    also would be Summarys and descriptions for those languages provided by the
> >    program
> 
> Unluckily I have no ways to provide a translation for such fields in the SPEC
> file because upstream do not provide them and I'm not a polyglot.
That's why I wrote "would be nice" ;)

> Anyway I added the Italian translations for Summary and Description. Of course
> other languages are welcome :)
You can also add a German translation if you want:
Summary(de): Grafisches Frontend für SyncEvolution
%description -l de
Genesis ist ein grafisches Frontend für SyncEvolution welches in PyGTK
geschrieben ist.
Es macht einen Zugriff auf SyncEvolution möglich, ohne die Kommandozeile nutzen
zu
müssen und gibt grafisch Rückmeldung über Transaktionen.

(Sorry I didn't provide this translation a bit earlier)

> > Once the macro-consistency issue is fixed I will approve this package.
> > Everything else looks good. Very nice work Andrea!  
> 
> Thanks!
> 
> http://musuruan.fedorapeople.org/genesis.spec
> http://musuruan.fedorapeople.org/genesis-0.4.2.1-2.fc12.src.rpm
> 
> Changelog:
> - More consistent macro usage
> - Added Italian summary and description  

The package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.