[Bug 545046] Review Request: CVector - ANSI C API for Dynamic Arrays

bugzilla at redhat.com bugzilla at redhat.com
Wed Dec 9 06:00:59 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=545046





--- Comment #5 from Takanori MATSUURA <t.matsuu at gmail.com>  2009-12-09 01:00:58 EDT ---
Spec URL: http://t-matsuu.sakura.ne.jp/mock/CVector/CVector.spec
SRPM URL:
http://t-matsuu.sakura.ne.jp/mock/CVector/CVector-1.0.3-3.20090805.fc12.src.rpm 

(In reply to comment #4)
> - The Summary, Group and Requires fields of the subpackages are still not
> tabbed correctly.

It's not clear for me.
Does the latest spec file refrain what you mean?


> - LIBDIR should have no effect in %build, since nothing is installed yet. You
> can safely change
>  make all CC="%{__cc}" CFLAGS="%{optflags}" LIBDIR="%{_libdir}"
> to
>  make CFLAGS="%{optflags}" %{?_smp_mflags}
> 
> where %{?_smp_mflags} enables parallel compilation.

Fixed.


> - You are mixing macros: %{buildroot} vs. $RPM_BUILD_ROOT, %{optflags} vs.
> $RPM_OPT_FLAGS. Choose a style and stick with it.

I choose "macros" policy.


> - You don't have to ship the static library at all - you can just remove it at
> the end of %install.

This package may be used by scientific programmer which have the computer with
huge memory area.

They sometimes link libraries as static for the "performance" with their own
risk.  Other scientific libraries such as blas/lapack or fftw also have static
libraries in their package.  So I suppose there is no problem that I pack
static libraries as a separate subpackage.


> - Please do not use wildcards where they are not necessary: change
>  %{_libdir}/*.so.*
> to
>  %{_libdir}/libCVector.so.*
> and the same thing with *.so, and
>  %{_includedir}/*
> to
>  %{_includedir}/CVector.h  

Fixed.


Thank you for continuous reviewing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list