[Bug 226567] Merge Review: xmltex

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226567





--- Comment #3 from Michal Hlavinka <mhlavink at redhat.com>  2009-12-10 12:49:34 EDT ---
I've forgotten one:

5) wrong buildroot tag

https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

"""The BuildRoot value MUST be below %{_tmppath}/ and MUST contain at least
%{name}, %{version} and %{release}"""

The recommended values for the BuildRoot tag is 

%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

Btw, if used only for Fedora 10+, there's no need to define BuildRoot tag at
all:

"""The RPM in Fedora 10 defines a default buildroot so in Fedora 10 and above
it is no longer necessary to define a buildroot tag."""

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.