[Bug 530021] Review Request: moovida - Media Center

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=530021





--- Comment #29 from Matthias Saou <matthias at rpmforge.net>  2009-12-11 05:59:28 EDT ---
In this particular case, I think the rpmlint errors should be treated as false
positives. That check is meant to find scripts meant to be executed directly
which would be lacking +x. Here, I seriously doubt these python files are meant
to be executed "standalone", so it's just the developers who have introduced a
useless though harmless "#!/usr/bin/python" at the top of the file.

Various overlapping suggestions :
 * Poke upstream about it if you want, it could be easily fixed in the next
release
 * Put a simple comment above the relevant line of %files with something like
"# Some *.py files have a useless hashbang line we should just ignore"
 * Include a patch which would remove those lines and silence rpmlinl

I think the comment should be fine. Since those are *launcher.py files, maybe
they are occasionally run directly by some to debug things. Anyway, in the end,
quite a minor issue if you ask me :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.